Skip to content

Release dry check: all secrets checked by name; preflight checks bundle id and display name - #164

Merged
Skeyelab merged 1 commit into
mainfrom
release-dry
Nov 16, 2026
Merged

Skeyelab merged 1 commit into
mainfrom
release-dry

Conversation

@Skeyelab

Copy link
Copy Markdown
Member

This comes from a dry check of the release path before the first v1.0.0 tag. Two small fixes, no secrets touched.

Part of #28

Changes

  • release.yml: the secret check covers all eight. Before, it checked only ASC_KEY_P8 and the two .p12s. A missing DEVELOPMENT_TEAM, ASC_KEY_ID, ASC_ISSUER_ID or .p12 password passed that step and then failed later in signing or the upload, with a less clear error. The step now checks each secret by name, never reading a value, and lists the missing ones:
    ::error::Missing release secrets: ASC_ISSUER_ID DIST_CERT_PASSWORD. Add them, or give this repository access to the org secrets…
  • preflight.sh checks two more things:

Tests

  • scripts/test-preflight.sh: the good fake app now has a display name. New failing cases for a wrong bundle id and a missing CFBundleDisplayName were red first, then green. All preflight tests pass.
  • The release step's script, with fake flags: all eight set → exit 0; two unset → exit 1, naming exactly those two.
  • actionlint is clean.
  • Real preflight on a local Release build with tag-like versions (MARKETING_VERSION=1.0.0, CURRENT_PROJECT_VERSION=42.1): every check passes, including bundle id dev.ericdahl.ControllerBridge and display name DeckBridge.

🤖 Generated with Claude Code

https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1

… id and display name

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VCgWWsrZ4EvHNNNTAe7RC1
@Skeyelab Skeyelab added this to the v1.0: native Mac app milestone Nov 16, 2026
@Skeyelab
Skeyelab enabled auto-merge November 16, 2026 05:17
@Skeyelab
Skeyelab merged commit 77e34cf into main Nov 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant